Skip to content

Furyf4virtualbaro #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Furyf4virtualbaro #942

wants to merge 3 commits into from

Conversation

@ACherchel
Copy link

@ACherchel ACherchel commented Nov 2, 2025 •
edited by coderabbitai bot
Loading

Pull-Request requirements

Mandatory Review for All New Flight Controllers

  • All new flight controllers must undergo the Betaflight review process, regardless of whether they use an existing target.
  • Manufacturers may reuse the same target for multiple designs, but each new hardware release must be reviewed before approval.

Hardware Compliance Requirements

These measures help maintain high standards and ensure compatibility within the Betaflight ecosystem.

If you have any questions or need guidance, feel free to reach out to the Betaflight development team.

Housekeeping

  • Pull-Request only from a custom branch, not master.
  • Replace this text with details of your own.

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • Chores
    • Reconfigured barometer sensor selection for the FURYF4OSD device configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 2, 2025 •
edited
Loading

Caution

Review failed

Failed to post review comments

Walkthrough

This PR modifies the FURYF4OSD board configuration to disable two hardware barometer drivers (BMP280 and DPS310) and enable the virtual barometer instead. This changes which barometer subsystem is compiled for this flight controller variant.

Changes

Cohort / File(s) Summary
Barometer configuration
configs/FURYF4OSD/config.h		 Disabled USE_BARO_BMP280 and USE_BARO_DPS310; enabled USE_BARO_VIRTUAL. Added trailing "#" marker.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

This is a straightforward configuration change affecting compile-time feature flags in a single board config file with no logic modifications.

Possibly related PRs

  • Add HAKRCH743 #757: Modifies barometer selection macros in board config headers; enables hardware barometers instead of disabling them.

Suggested labels

Housekeeping

Suggested reviewers

  • haslinghuis
  • ot0tot
  • nerdCopter

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is not filled out and consists entirely of the repository's template text without any author-provided details. The template explicitly states "Replace this text with details of your own," but this instruction has not been followed. Additionally, the description discusses requirements for new flight controller submissions, which is not aligned with the actual changeset that modifies barometer configuration settings in an existing target. The description does not explain what changes were made, why they were made, or what the impact is. Replace the template boilerplate with a meaningful description of the changes. Explain that the pull request disables BMP280 and DPS310 barometers and enables the virtual barometer for the Furyf4 target, including the rationale for this change and any testing performed. Ensure the description is specific to this configuration change, not generic flight controller submission requirements.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Furyf4virtualbaro" is related to the changeset, as it references the virtual barometer functionality that is the focus of the change. However, the title is written in a technical shorthand format (device name + feature name) rather than as a clear, descriptive sentence. While it does communicate that the change involves switching to a virtual barometer for the Furyf4 target, it lacks proper formatting and could be clearer to someone quickly scanning the pull request history.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis haslinghuis closed this Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ACherchel @haslinghuis